Zhou Zheng Sheng has posted comments on this change. Change subject: misc: use approriate raise form in RollbackContext ......................................................................
Patch Set 2: I would prefer that you didn't submit this Test on python-pep8-0.6.0-2.el6.noarch, pass. However, making these three arguments together as a tuple actually is applying the one argument form of the raise statement. The traceback is packaged in the tuple as part of the exception value, but not provided to the raise statement as context, so the printed traceback info is not accurate. Reporting W602 on three argument form of the raise statement is a bug of the pep8 check tool. It is discussed at https://github.com/jcrocholl/pep8/issues/34 , and fixed at upstream commit c52a3d56b5e of git://github.com/jcrocholl/pep8.git . I report a bug for EPEL python-pep8 at https://bugzilla.redhat.com/show_bug.cgi?id=878753 . I hope the bug fix can be backported. For now, we can yum install python-pip, then pip install pep8 to get the latest stable version of pep8. -- To view, visit http://gerrit.ovirt.org/9360 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I390771ad2465069400bd777c4463019609ae17d8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
