Maor Lipchuk has posted comments on this change. Change subject: upgrade: Support upgrade to v4 from v3 ......................................................................
Patch Set 1: (4 comments) https://gerrit.ovirt.org/#/c/63547/1/vdsm/storage/imageRepository/formatConverter.py File vdsm/storage/imageRepository/formatConverter.py: Line 343: log.debug("Switching the cluster lock for domain %s", domain.sdUUID) Line 344: domain._clusterLock = newClusterLock Line 345: Line 346: def v4DomainConverter(repoPath, hostId, domain, isMsd): Line 347: log = logging.getLogger('Storage.v4DomainConverter') > +1 Fixed Line 348: targetVersion = 4 Line 349: Line 350: if domain.getStorageType() in sd.BLOCK_DOMAIN_TYPES: Line 351: log.debug("Trying to upgrade domain %s to tag based metadata " PS1, Line 348: targetVersion = 4 > Umm, you don't seem to actually do anything with it. I assume you're missin I was thinking to reuse __convertDomainMetadataToTags instead, though I will try the cleaner way as suggested PS1, Line 350: if domain.getStorageType() in sd.BLOCK_DOMAIN_TYPES: : log.debug("Trying to upgrade domain %s to tag based metadata " : "version %s", domain.sdUUID, targetVersion) : : __convertDomainMetadataToTags(domain, targetVersion) > V3 is already based on tags, and we don't support direct upgrade from [0, 2 see my comment above Line 354: __convertDomainMetadataToTags(domain, targetVersion) Line 355: Line 356: else: Line 357: log.debug("Skipping the upgrade to tag based metadata version %s " Line 358: "for the domain %s", targetVersion, domain.sdUUID) > Please use the happy path idiom: Thinking about this again, Is there any reason to filter block and file SDs regarding upgrade to V4. I will remove it for now, please let me know if there was something I've been missing. Line 359: Line 360: Line 361: _IMAGE_REPOSITORY_CONVERSION_TABLE = { Line 362: ('0', '2'): v2DomainConverter, -- To view, visit https://gerrit.ovirt.org/63547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a66346b91e49480d391116ba8ee8b8294f53ec4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
