Petr Horáček has posted comments on this change. Change subject: net: Link setup module - includes bond setup logic. ......................................................................
Patch Set 22: Code-Review-1 (7 comments) https://gerrit.ovirt.org/#/c/62831/22/lib/vdsm/network/link/setup.py File lib/vdsm/network/link/setup.py: PS22, Line 53: skaves slaves PS22, Line 57: a SetupBonds transaction. is it needed with this approach? we should be in consistent state after every sub-stransaction (with bond). PS22, Line 67: attrs attrs contains the final state. we must save only currently attached slaves (and set options). PS22, Line 80: # TODO: Options : # attrs.get('options', '') please move this before final setBonding() so it is obvious that we save attrs only when all is configured. PS22, Line 95: # TODO: Options : # attrs.get('options', '') move this as well to be consistent. https://gerrit.ovirt.org/#/c/62831/21/tests/network/link_setup_test.py File tests/network/link_setup_test.py: PS21, Line 47: set frozen PS21, Line 49: set frozen -- To view, visit https://gerrit.ovirt.org/62831 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8f01a401cb1b96e357bc462e528a2a547c59c24 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
