Edward Haas has posted comments on this change. Change subject: net test: test_ip_info - wait for IP settings with address ......................................................................
Patch Set 4: Verified+1 (1 comment) https://gerrit.ovirt.org/#/c/63660/2/lib/vdsm/network/netlink/waitfor.py File lib/vdsm/network/netlink/waitfor.py: Line 41: return Line 42: Line 43: Line 44: @contextmanager Line 45: def waitfor_ipv4_addr(iface, address=None, timeout=10): > please add a comment that :address: must be in CIDR form (if prefix length Done Line 46: """ Line 47: Silently block until an ipv4 global scope address message is detected from Line 48: the kernel (through netlink). Line 49: :param iface: The device name. -- To view, visit https://gerrit.ovirt.org/63660 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c2832c1ec7614e1df9c291a9f3ab2e4a1134242 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
