Edward Haas has posted comments on this change. Change subject: net tests: replace wait_for_ipv6 with waitfor.waitfor_ipv6_addr ......................................................................
Patch Set 1: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/63665/1/tests/network/netinfo_test.py File tests/network/netinfo_test.py: Line 429: IPV6_ADDR_CIDR = self._cidr_form(IPV6_ADDR, IPV6_NETPREFIX_LEN) Line 430: ipwrapper.addrAdd(server, IPV6_ADDR, IPV6_NETPREFIX_LEN, family=6) Line 431: ipwrapper.linkSet(server, ['up']) Line 432: with dnsmasq_run(server, ipv6_slaac_prefix=IPV6_NETADDRESS + '::'): Line 433: with waitfor.waitfor_ipv6_addr(client, address=IPV6_ADDR_CIDR): You are waiting for the server IP on the client side? Line 434: ipwrapper.linkSet(client, ['up']) Line 435: Line 436: # Expecting link and global addresses on client iface Line 437: # The addresses are given randomly, so we sort them https://gerrit.ovirt.org/#/c/63665/1/tests/network/nettestlib.py File tests/network/nettestlib.py: Line 433 Line 434 Line 435 Line 436 Line 437 This one is a bit different from the one in waitfor. It also waits for link scope (can be chosen) and for 'new_addr' event. I guess we can add it to the waitfor version. -- To view, visit https://gerrit.ovirt.org/63665 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ec777a362519aa9240823181f809019b71aeea9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
