Dan Kenigsberg has uploaded a new change for review. Change subject: vdsmd.init: retire ifconfig ......................................................................
vdsmd.init: retire ifconfig Replace ifconfig with iproute2's /sbin/ip also in our init script. Drop an old irrelevant comment that mentions ifconfig. Change-Id: I27385f74653b209c18aa8594b89a409287b4f259 Signed-off-by: Dan Kenigsberg <[email protected]> --- M vdsm/netinfo.py M vdsm/vdsmd.init.in 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/85/9385/1 diff --git a/vdsm/netinfo.py b/vdsm/netinfo.py index b6d1a1f..7b28fae 100644 --- a/vdsm/netinfo.py +++ b/vdsm/netinfo.py @@ -274,9 +274,9 @@ def get(): d = {} routes = getRoutes() - # FIXME handle bridge/nic missing from ifconfig d['networks'] = {} nets = networks() + for netname in nets.iterkeys(): if nets[netname]['bridged']: devname = netname diff --git a/vdsm/vdsmd.init.in b/vdsm/vdsmd.init.in index 53ad8af..e1df196 100755 --- a/vdsm/vdsmd.init.in +++ b/vdsm/vdsmd.init.in @@ -179,7 +179,7 @@ } test_lo() { - if ! LC_ALL=C /sbin/ifconfig lo | /bin/grep -q UP; + if ! LC_ALL=C /sbin/ip lo | /bin/grep -q UP; then log_failure_msg "VDSMD: lo interface is down, can't run !" echo "VDSMD: lo interface is down, can't run !" > /dev/kmsg -- To view, visit http://gerrit.ovirt.org/9385 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I27385f74653b209c18aa8594b89a409287b4f259 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
