Irit Goihman has posted comments on this change. Change subject: jsonrpcvdscli: fix results of several commands ......................................................................
Patch Set 3: > This looks correct, if https://gerrit.ovirt.org/63408 was correcdt, > but > I think it was wrong, changing the return value from list of vms to > dict with a vmList key, conflicting the schema and possibly > breaking engine. Nir, can we talk about it offline? I don't see any conflict in the schema and a dict is returned now and before (just with different keys). We can test it further if you'd like. -- To view, visit https://gerrit.ovirt.org/63483 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f6b5862a69ea3d5140352fce7dda51bb95bab9c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
