Dan Kenigsberg has posted comments on this change.
Change subject: fix: sockets/cores retrieval from cpu topology
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/caps.py
Line 115: sockets = 1
Line 116: cores = 1
Line 117: if topology:
Line 118: sockets = int(topology[0].getAttribute('sockets'))
Line 119: cores = int(topology[0].getAttribute('cores'))
please add an "else" clause, with a proper setting og sockets/core. You can
take the code from what we had before commit 90b3392ccc88. reporting "1 core"
is a quite wrong.
Also add a comment linking to the libvirt bug that cause this.
Line 120: cells = host.getElementsByTagName('cells')[0]
Line 121: topology = {'cells': int(cells.getAttribute('num')),
Line 122: 'sockets': sockets,
Line 123: 'cores': cores,
--
To view, visit http://gerrit.ovirt.org/9386
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I343db03f9cf6eefc28f993d269c6c082e7695af5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Timothy Asir <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
