Nir Soffer has posted comments on this change. Change subject: mount: Wait for systemd temporary mount unit ......................................................................
Patch Set 5: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/56544/5/lib/vdsm/storage/mount.py File lib/vdsm/storage/mount.py: Line 224: Line 225: def mount(self, mntOpts=None, vfstype=None, timeout=None, cgroup=None): Line 226: mount = supervdsm.getProxy().mount if os.geteuid() != 0 else _mount Line 227: self.log.info("mounting %s at %s", self.fs_spec, self.fs_file) Line 228: > spurious? I think it was intended, breaking the code to 3 "paragraphs", see umount(). Line 229: with utils.stopwatch("%s mounted" % self.fs_file, log=self.log): Line 230: mount(self.fs_spec, self.fs_file, mntOpts=mntOpts, vfstype=vfstype, Line 231: timeout=timeout, cgroup=cgroup) Line 232: Line 229: with utils.stopwatch("%s mounted" % self.fs_file, log=self.log): Line 230: mount(self.fs_spec, self.fs_file, mntOpts=mntOpts, vfstype=vfstype, Line 231: timeout=timeout, cgroup=cgroup) Line 232: Line 233: # This is a hack to wait unilt the udev events generated when adding a unilt > until Line 234: # new mount are processed. Line 235: # TODO: use pyudev to wait for more specific event Line 236: with utils.stopwatch("Waiting for mount udev events", log=self.log): Line 237: udevadm.settle(5) Line 233: # This is a hack to wait unilt the udev events generated when adding a Line 234: # new mount are processed. Line 235: # TODO: use pyudev to wait for more specific event Line 236: with utils.stopwatch("Waiting for mount udev events", log=self.log): Line 237: udevadm.settle(5) > Could you drop a word about this magical 5 seconds? I think we need to add This was copied from the tests, I think we should use the configuration for this so we can tweak this in the field. We have now irs:scsi_settle_timeout used after iscsi/fc rescan and after connecting to scsi target. For long term we should get rid of settle and wait for the specific udev event instead, just need more time to work on this. Line 238: Line 239: def umount(self, force=False, lazy=False, freeloop=False, timeout=None): Line 240: umount = supervdsm.getProxy().umount if os.geteuid() != 0 else _umount Line 241: self.log.info("unmounting %s", self.fs_file) -- To view, visit https://gerrit.ovirt.org/56544 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b0318eb534f781f127882983527e1a221820478 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
