Nir Soffer has posted comments on this change.

Change subject: lib: api: allow to return prebuilt responses
......................................................................


Patch Set 12:

(2 comments)

https://gerrit.ovirt.org/#/c/61474/12/lib/vdsm/common/api.py
File lib/vdsm/common/api.py:

Line 61:         _log.debug("FINISH %s response=%s (passthrough)",
Line 62:                    func.__name__, ret)
Line 63:         return ret
Line 64:     else:
Line 65:         _log.debug("FINISH %s response=%s", func.__name__, ret)
I don't understand why we duplicating logging here, we can handle valid 
response bellow...
Line 66:         if ret is None:
Line 67:             return response.success()
Line 68:         else:


Line 63:         return ret
Line 64:     else:
Line 65:         _log.debug("FINISH %s response=%s", func.__name__, ret)
Line 66:         if ret is None:
Line 67:             return response.success()
Here:

    # Explain this hack...
    if response.is_valid(ret):
        return ret
    
    return response.success(**ret)
Line 68:         else:


-- 
To view, visit https://gerrit.ovirt.org/61474
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1c6ab93271e2c5619483446403068ddd95ecb4
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Irit Goihman <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/admin/lists/[email protected]

Reply via email to