Nir Soffer has submitted this change and it was merged. Change subject: jobs: Change state to aborted only when successful ......................................................................
jobs: Change state to aborted only when successful We were changing the job state to aborted even if the _abort function failed. This meant that a job could show up as aborted even though it is still accessing storage. The solution is to only change state after _abort finishes. Also add comments to require _abort implementations to raise on error. Change-Id: I09bb5a22ee0012627f078fdd9f6b472045a1b727 Signed-off-by: Adam Litke <ali...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/63936 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer <nsof...@redhat.com> --- M lib/vdsm/jobs.py M tests/jobsTests.py 2 files changed, 9 insertions(+), 1 deletion(-) Approvals: Adam Litke: Verified Nir Soffer: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63936 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09bb5a22ee0012627f078fdd9f6b472045a1b727 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
