Nir Soffer has posted comments on this change. Change subject: monitor: Rename storage domain monitor threads ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/63524/4/vdsm/storage/monitor.py File vdsm/storage/monitor.py: Line 252: class MonitorThread(object): Line 253: Line 254: def __init__(self, sdUUID, hostId, interval, changeEvent, checker): Line 255: self.thread = concurrent.thread(self._run, logger=log.name, Line 256: name="monitor/" + sdUUID[:7]) > It's theoretically possible to have a pair of domains with matching short u Yes, name is not unique. Today all threads are named (in htop and ps) "vdsm", so having two threads named "monitor/xxxyyy" is way better. We can use full uuid for the python thread name, and short uuid for the system names, but then python thread names will be too long. I assume that chance of same short uuid is small. Line 257: self.stopEvent = threading.Event() Line 258: self.domain = None Line 259: self.sdUUID = sdUUID Line 260: self.hostId = hostId -- To view, visit https://gerrit.ovirt.org/63524 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86480d2205be602cbffe6c37acd63a67a4aa2c96 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
