Hello Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/63973
to review the following change.
Change subject: virt: Ensure uncaught exceptions on disconnect events are caught
......................................................................
virt: Ensure uncaught exceptions on disconnect events are caught
Previously we did not catch unhandled exceptions and they
were not logged either which made it pretty difficult to
actually detect any existing issue in the first place.
This patch ensures that future unhandled exceptions are
at least logged so we'll be aware of them.
Change-Id: Ie5b91acad0e5d9c5a973b626f10fc0d543e6bcc6
Backport-To: 4.0
Bug-Url: https://bugzilla.redhat.com/1371264
Bug-Url: https://bugzilla.redhat.com/1349383
Signed-off-by: Vinzenz Feenstra <[email protected]>
Reviewed-on: https://gerrit.ovirt.org/59868
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani <[email protected]>
---
M vdsm/virt/vm.py
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/73/63973/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 61e8957..4a4fa91 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -883,6 +883,7 @@
self.conf['clientIp'] = clientIp
self._clientPort = clientPort
+ @utils.traceback()
def _timedDesktopLock(self):
# This is not a definite fix, we're aware that there is still the
# possibility of a race condition, however this covers more cases
--
To view, visit https://gerrit.ovirt.org/63973
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie5b91acad0e5d9c5a973b626f10fc0d543e6bcc6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/admin/lists/[email protected]
