Irit Goihman has posted comments on this change.

Change subject: functional tests: fix supervdsmServer test
......................................................................


Patch Set 19:

(1 comment)

https://gerrit.ovirt.org/#/c/61902/19/tests/functional/supervdsmFuncTests.py
File tests/functional/supervdsmFuncTests.py:

Line 24: from pwd import getpwnam
Line 25: import os
Line 26: 
Line 27: 
Line 28: def dropPrivileges():
> This change is not needed to fix the issue, but is nice, so I'll ignore it.
sorry, it bothered me... :)
Line 29:         vdsm_uid, vdsm_gid = getpwnam(VDSM_USER)[2:4:]
Line 30:         os.setgroups([])
Line 31:         os.setgid(vdsm_gid)
Line 32:         os.setuid(vdsm_uid)


-- 
To view, visit https://gerrit.ovirt.org/61902
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c7e381809261cf330ef4f19c3fec5cd38254b1b
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Reply via email to