Nir Soffer has posted comments on this change. Change subject: Define the StorageDomain.reduce API ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/62853/3/lib/api/vdsm-api.yml File lib/api/vdsm-api.yml: Line 8216: - description: A UUID to be used for tracking the job progress Line 8217: name: jobID Line 8218: type: *UUID Line 8219: Line 8220: - description: The UUID of the Storage Domain > Why isn't the SD UUID the first param? (I see in most cases it is, that's a New storage apis are always running in a job, and accept job_id generated by engine as the first argument. See for example SDM.copy_data. Old apis running asynchronously return a task uuid. If communication between engine and vdsm brake before engine got a reply, it does not have any way to detect the task created in vdsm. New apis also use complex argument(s) so we don't have to pass around so many arguments via the different layers, and we can validate the input automatically using properties, see vdsm/storage/sdm/api/copy_data.py. Line 8221: name: storagedomainID Line 8222: type: *UUID Line 8223: Line 8224: - description: A block device GUID -- To view, visit https://gerrit.ovirt.org/62853 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5e41b9fa2df4ffef1f3cbb9fbfc57022ffedd9a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
