Nir Soffer has posted comments on this change. Change subject: storage: Add inplace virt-sparsify support ......................................................................
Patch Set 13: Yaniv, what sparsify-inplace is doing is basically adding your disk to a special minimal vm, and running fstrim inside the vm. If can sparsify only the top volume as the other volumes are read only, we cannot change history unless you ask to remove it (merge). According to Richard, sparsify does not work on: - guest files backed with NFS (before v4.2) - guest storage on regular LVs (not using lvm-thinp) So it should work with NFS >= 4.2, local storage, maybe glusterfs, probably not because of fuse. Shmuel, did you try this with all storage types? can you report interesting results? -- To view, visit https://gerrit.ovirt.org/57347 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ac2bb1fbd2acbe0fc47694d17313c6ccd01a227 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Shmuel Leib Melamud <[email protected]> Gerrit-Reviewer: Shmuel Melamud <[email protected]> Gerrit-Reviewer: Yaniv Kaul <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
