Martin Sivák has posted comments on this change. Change subject: logging: add and use new devel logger ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/62209/5/lib/vdsm/vdscli.py File lib/vdsm/vdscli.py: PS5, Line 40: _devel I know you do no like long names and it makes PEP 8 compliance harder, but this really should be called log_devel or something like that (zen of python: explicit is better, readable counts, namespaces are good and so on). Also I do not really understand the underscore either, it is common for class members, but there are other methods to hide module global symbols from importers (like __all__). -- To view, visit https://gerrit.ovirt.org/62209 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5061e78dde7aceffce9ae90fe5e2c2ad8c00f886 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
