Edward Haas has posted comments on this change. Change subject: net: Use Linux bonds with OVS networks ......................................................................
Patch Set 30: (1 comment) https://gerrit.ovirt.org/#/c/63119/30/lib/vdsm/network/netswitch.py File lib/vdsm/network/netswitch.py: PS30, Line 82: but not successfully deployed (not saved in running config). > this should not be the problem now. the problem is when there is bond creat During the setup steps, the in-memory running config is updated, however, if an error/failure occurs in the middle, the config is not saved persistently, it is just used to revert back any partial changes. Therefore, the special handling here is still needed and has nothing to do with the atomicity of bond setup. -- To view, visit https://gerrit.ovirt.org/63119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6aeff335949a6e2996f7c3faa524df784dff1b01 Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
