Francesco Romani has posted comments on this change. Change subject: API: modernize VM methods ......................................................................
Patch Set 9: (2 comments) https://gerrit.ovirt.org/#/c/61475/9/vdsm/API.py File vdsm/API.py: Line 37: from vdsm import supervdsm Line 38: from vdsm import throttledlog Line 39: from vdsm import jobs Line 40: from vdsm import v2v Line 41: from vdsm.common import api as wrapapi > Can we use the original name? I had a name clash. Not sure if it applies nowadays. Will try, and if still relevant I'll add a comment to explain. Line 42: from vdsm.host import api as hostapi Line 43: from vdsm.logUtils import AllVmStatsValue, Suppressed Line 44: from vdsm.storage import clusterlock Line 45: from vdsm.storage import misc Line 127: @contextmanager Line 128: def _vm_instance(self): Line 129: v = self._cif.vmContainer.get(self._UUID) Line 130: if not v: Line 131: raise exception.NoSuchVM() > Nice cleanup! Good idea, will implement. Line 132: yield v Line 133: Line 134: @wrapapi.method Line 135: def changeCD(self, driveSpec): -- To view, visit https://gerrit.ovirt.org/61475 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e2e238fc632df97b63f7bb2a6293fe1c392a842 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Irit Goihman <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
