Nir Soffer has posted comments on this change. Change subject: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow. ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/64169/4//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2016-09-20 01:41:01 +0300 Line 4: Commit: Maor Lipchuk <mlipc...@redhat.com> Line 5: CommitDate: 2016-09-20 03:56:54 +0300 Line 6: Line 7: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow. We don't use such titles ([FOO]). You can name this after the module or subsystem modified, or the feature, which is actually "qcow3". - qcow2 == qcow_compat 0.10 - qcow3 == qcow_compat 1.1 I don't know why qemu are not calling this "version", this is how it is stored in qcow header. Line 8: Line 9: Add kwargs of storage domain metadata to indicate the Line 10: appropriate qcow level to use for create and convert operations. Line 11: -- To view, visit https://gerrit.ovirt.org/64169 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
