Petr Horáček has posted comments on this change. Change subject: net: edit bond detached from bridge but still attached to a vlan ......................................................................
Patch Set 9: Verified+1 (3 comments) func_bond_basic_test passed https://gerrit.ovirt.org/#/c/63723/8/tests/network/func_bond_basic_test.py File tests/network/func_bond_basic_test.py: PS8, Line 112: ifdown(BOND_ > Why is this needed? This info exists in the source control history. Done PS8, Line 115: self.update_netinfo() > Can you add a comment on why it is needed? Done PS8, Line 124: with self._test_detach_used_bond_from_bri > Calling this without a 'with'? What happens when it reaches the 'yield'? Aha, it does not, it just returns <contextlib._GeneratorContextManager object at 0x7f73f1554f98> -- To view, visit https://gerrit.ovirt.org/63723 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
