Milan Zamazal has posted comments on this change. Change subject: hostdev: prefer numa nodes close to device MMIO ......................................................................
Patch Set 16: (2 comments) https://gerrit.ovirt.org/#/c/60640/16/vdsm/virt/vm.py File vdsm/virt/vm.py: PS16, Line 1527: [device for devices in self._devices.values() for : device in devices] This is the actual complicated construct. https://gerrit.ovirt.org/#/c/60640/15/vdsm/virt/vmxml.py File vdsm/virt/vmxml.py: PS15, Line 519: [dev_object.numa_node for dev_object in devices if : dev_object.is_hostdevice and dev_object.numa_node] > How is this obfuscation? It literally reads "list of numa nodes for host de I'm sorry, a misplaced comment, it belonged to vm.py. -- To view, visit https://gerrit.ovirt.org/60640 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9bc795d2f5bad76ebf1e1bff391b3bc71037fffb Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
