Dan Kenigsberg has submitted this change and it was merged.

Change subject: logging: add and use new devel logger
......................................................................


logging: add and use new devel logger

After rhbz#1264149 we learned that way that the warnings
module doesn't really fit the needs of Vdsm.

This patch adds and make the code use a new logger, 'devel',
set by default to ERROR level, to be used for the messages
that only the developers should see.

To see more 'devel' messages, which can be useful for troubleshooting,
edit /etc/vdsm/logger.conf to read like:

    [logger_devel]
    level=WARNING

This change will be persistent across Vdsm restarts.
You can also enable the warnings at runtime, like any other logger,
using

    vdsClient -s 0 setLogLevel devel WARNING

The change made using vdsClient will be lost when Vdsm is stopped.

Change-Id: I5061e78dde7aceffce9ae90fe5e2c2ad8c00f886
Related-To: https://bugzilla.redhat.com/1364149
Bug-Url: https://bugzilla.redhat.com/1369822
Bug-Url: https://bugzilla.redhat.com/1377069
Backport-To: 4.0
Signed-off-by: Francesco Romani <from...@redhat.com>
Reviewed-on: https://gerrit.ovirt.org/62209
Reviewed-by: Nir Soffer <nsof...@redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Reviewed-by: Simone Tiraboschi <stira...@redhat.com>
---
M README.logging
M lib/api/vdsmapi.py
M static/etc/vdsm/logger.conf.in
3 files changed, 15 insertions(+), 9 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Nir Soffer: Looks good to me, approved
  Simone Tiraboschi: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/62209
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5061e78dde7aceffce9ae90fe5e2c2ad8c00f886
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to