Jenny Tokar has posted comments on this change. Change subject: Add new api to get the IO tune policies for all vms ......................................................................
Patch Set 2: (4 comments) https://gerrit.ovirt.org/#/c/63748/2/vdsm/virt/vm.py File vdsm/virt/vm.py: PS2, Line 2579: getIoTunePolicyResponse > what's the need for this? I didn't want to remove the current api for getting the io tune policy for a single vm. The api relies on this method. I could remove it and move the handling of the response to API.py. PS2, Line 2601: getIoTuneResponse > ditto I didn't want to remove the current api for getting the io tune info for a single vm. The api relies on this method. I could remove it and move the handling of the response to API.py. Line 2624: Line 2625: except libvirt.libvirtError as e: Line 2626: self.log.exception("getVmIoTune failed") Line 2627: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN: Line 2628: self.logger.error('noVM') > not sure you wanna keep this. why not? in case the method is called from the bulk api the error response is not returned (see getIoTune method that cleans it). if I'm logging the error at least there will be something that tells the user something failed. Line 2629: return response.error('noVM') Line 2630: else: Line 2631: self.logger.error('updateIoTuneErr', e.message) Line 2632: return response.error('updateIoTuneErr', e.message) Line 2627: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN: Line 2628: self.logger.error('noVM') Line 2629: return response.error('noVM') Line 2630: else: Line 2631: self.logger.error('updateIoTuneErr', e.message) > ditto same Line 2632: return response.error('updateIoTuneErr', e.message) Line 2633: Line 2634: return response.success(ioTuneList=resultList) Line 2635: -- To view, visit https://gerrit.ovirt.org/63748 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16ead268367901ae85e47fb71104e23705f0e0e1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Jenny Tokar <jto...@redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrej...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenny Tokar <jto...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Phillip Bailey <phbai...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Roman Mohr <rm...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yanir Quinn <yqu...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
