Milan Zamazal has posted comments on this change. Change subject: logging: Unify SimpleLogAdapter format ......................................................................
Patch Set 1: (1 comment) Except for the commit comment I support this change. https://gerrit.ovirt.org/#/c/64227/1//COMMIT_MSG Commit Message: Line 23: This matches the format we used lately in many logs for adding message Line 24: details. Line 25: Line 26: Here is an example log: Line 27: https://paste.fedoraproject.org/431636/raw/ Let's not use temporary references in commit messages. Line 28: Line 29: Change-Id: Ib4edb64d214e515c9cfc45175f6cfee4340d28de -- To view, visit https://gerrit.ovirt.org/64227 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4edb64d214e515c9cfc45175f6cfee4340d28de Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
