Maor Lipchuk has posted comments on this change. Change subject: qemuimg: Add kwargs optional parameter for qcow. ......................................................................
Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/64169/7/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line 108: Line 109: if format: Line 110: cmd.extend(("-f", format)) Line 111: if format == FORMAT.QCOW2: Line 112: cmd.extend(('-o', 'compat=' + qcow2_compat)) > We need to support the qcow configuration introduced in 4.0. I'll add this check although I think that making this check will reduce the flexibility of maintaining the versions. The use of this method should be from the VDSM, so we should control which version we pass to it. Line 113: Line 114: if backing: Line 115: if not os.path.isabs(backing): Line 116: cwdPath = os.path.dirname(image) Line 306: if rc != 0: Line 307: raise QImgError(rc, out, err) Line 308: Line 309: Line 310: def _qcow2_def_compat(): > Please rename to default_qcow2_compat Done Line 311: value = config.get('irs', 'qcow2_compat') Line 312: if value not in _QCOW2_COMPAT_SUPPORTED: Line 313: raise exception.InvalidConfiguration( Line 314: "Unsupported value for irs:qcow2_compat: %r" % value) -- To view, visit https://gerrit.ovirt.org/64169 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
