Petr Horáček has posted comments on this change.

Change subject: net: Setup validation for OVS - Check nics usage
......................................................................


Patch Set 5: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/64212/4/lib/vdsm/network/ovs/validator.py
File lib/vdsm/network/ovs/validator.py:

PS4, Line 80: get('nic')
> Nope, that will not work when key exists with value of None.
aha, sorry, i see now


-- 
To view, visit https://gerrit.ovirt.org/64212
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1ed8805f7e1b84e784feef14c5378b41af1cbf1
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to