Piotr Kliczewski has posted comments on this change.

Change subject: contrib: Simple jsonrpc client
......................................................................


Patch Set 18:

(3 comments)

https://gerrit.ovirt.org/#/c/35181/18//COMMIT_MSG
Commit Message:

Line 27:     # jsonrpc StorageDomain.activate -f sd-activate
Line 28:     ...
Line 29: 
Line 30:     where sd-activate file content is:
Line 31:     storagedomainID=75ab40e3-06b1-4a54-a825-2df7a40b93b2,
Now we use json in the file. please update here as well.
Line 32:     storagepoolID=b3f6fa00-b315-4ad4-8108-f73da817b5c5
Line 33: 
Line 34: It is also possible to read parameters from standard input, creating
Line 35: complex parameters interactively:


Line 34: It is also possible to read parameters from standard input, creating
Line 35: complex parameters interactively:
Line 36: 
Line 37:     # jsonrpc StorageDomain.activate -f -
Line 38:     storagedomainID=75ab40e3-06b1-4a54-a825-2df7a40b93b2,
and here
Line 39:     storagepoolID=b3f6fa00-b315-4ad4-8108-f73da817b5c5
Line 40:     (Press Ctrl + D to finish)
Line 41: 
Line 42: Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084


https://gerrit.ovirt.org/#/c/35181/18/contrib/jsonrpc
File contrib/jsonrpc:

PS18, Line 72: import six
why do we need it?


-- 
To view, visit https://gerrit.ovirt.org/35181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <toni+ov...@midokura.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to