Irit Goihman has posted comments on this change. Change subject: utils: build cert paths in single place ......................................................................
Patch Set 12: (1 comment) https://gerrit.ovirt.org/#/c/52354/12/vdsm/sos/vdsm.py.in File vdsm/sos/vdsm.py.in: Line 104: self.addCopySpec("/tmp/vds_bootstrap*") Line 105: self.addCopySpec("/etc/vdsm/*") Line 106: logsize = self.getOption('logsize') Line 107: self.__addCopySpecLogLimit("/var/log/vdsm/*", logsize) Line 108: self._addVdsmRunDir() > key is still not collected. is it intentional? I'm working on a change now, I only rebased the patch and didn't refer the comments. Line 109: self.addCopySpec("@HOOKSDIR@") Line 110: self.addCopySpec("@VDSMLIBDIR@") Line 111: self.addCopySpec("/var/log/ovirt.log") Line 112: self.addCopySpec("/var/log/sanlock.log") -- To view, visit https://gerrit.ovirt.org/52354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org