Nir Soffer has posted comments on this change. Change subject: Live Merge: Remove volume run link after live merge ......................................................................
Patch Set 9: (2 comments) https://gerrit.ovirt.org/#/c/59725/8/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py: Line 821: """ Line 822: volRunlink = os.path.join(constants.P_VDSM_STORAGE, Line 823: self.sdUUID, imgUUID, volUUID) Line 824: try: Line 825: self.log.info("Unlinking volme runtime link: %r", volRunLink) Read again the comments in version 6 (your replied Done, but ignored the comments). Line 826: os.unlink(volRunLink) Line 827: except OSError as e: Line 828: if e.error != errno.ENOENT: Line 829: self.log.error("Failed to unlink volume run link: %r", https://gerrit.ovirt.org/#/c/59725/9/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py: Line 826: os.unlink(volRunLink) Line 827: except OSError as e: Line 828: if e.error != errno.ENOENT: Line 829: self.log.error("Failed to unlink volume run link: %r", Line 830: volRunlink) > I'd just raise without logging I commented about this in https://gerrit.ovirt.org/#/c/59725/6/vdsm/storage/blockSD.py Seems like leftover from older version. Line 831: raise Line 832: self.log.debug("Volume run link %r does not exist", volRunlink) Line 833: Line 834: -- To view, visit https://gerrit.ovirt.org/59725 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
