Dan Kenigsberg has posted comments on this change. Change subject: Integrate Smartcard support ......................................................................
Patch Set 7: I would prefer that you didn't submit this I'm sorry to spoil the party, but I'm not extremely happy about the proposed API. We've started a big shift towards a unified API, where all guest devices are defined in the "devices" section of the configuration. This would allow - in the future - to control device addresses and other properties, where a simple boolean is not enough. Please see the balloon device for more details. -- To view, visit http://gerrit.ovirt.org/8450 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7cdaef420c8381d588f6215e66e6a80dd9d2e44b Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Gal Hammer <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
