Nir Soffer has posted comments on this change. Change subject: storage: Add support for generation id to VolumeMetadata ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/64484/1/tests/storage_volume_metadata_test.py File tests/storage_volume_metadata_test.py: Line 98: PUUID=params['puuid'], Line 99: SIZE=str(params['size']), Line 100: TYPE=params['type'], Line 101: VOLTYPE=params['voltype'], Line 102: GENID=params['generation']) > Not sure if we really want to do this. OK Line 103: Line 104: with MonkeyPatchScope([[time, 'time', lambda: FAKE_TIME]]): Line 105: info = volume.VolumeMetadata(**params).legacy_info() Line 106: self.assertEqual(expected, info) -- To view, visit https://gerrit.ovirt.org/64484 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb71e1fc78f6c1e411e725b26c48411ffd04d0b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
