Adam Litke has posted comments on this change. Change subject: storage: Support generation id in sdm.copy_data ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/64488/1/vdsm/storage/sdm/api/copy_data.py File vdsm/storage/sdm/api/copy_data.py: Line 96: class CopyDataDivEndpoint(properties.Owner): Line 97: sd_id = properties.UUID(required=True) Line 98: img_id = properties.UUID(required=True) Line 99: vol_id = properties.UUID(required=True) Line 100: generation_id = properties.Integer(required=False, minval=0) > - generation Done Line 101: Line 102: def __init__(self, params, host_id, writable): Line 103: self.sd_id = params.get('sd_id') Line 104: self.img_id = params.get('img_id') Line 146: return sc.fmt2str(parent_vol.getFormat()) Line 147: Line 148: @property Line 149: def volume_operation(self): Line 150: return partial(self._vol.operation, self.generation_id) > Can we simplify to: Done Line 151: Line 152: @contextmanager Line 153: def prepare(self): Line 154: dom = sdCache.produce_manifest(self.sd_id) -- To view, visit https://gerrit.ovirt.org/64488 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I701e220f5c275dccaa3767768e2d1433fe033839 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
