Nir Soffer has posted comments on this change. Change subject: API: modernize VM methods ......................................................................
Patch Set 18: (2 comments) I think this patch is too big, lets change first the easy places where replacing the duplicate code with the new getter does not change the semantics. https://gerrit.ovirt.org/#/c/61475/18/vdsm/API.py File vdsm/API.py: Line 346 Line 347 Line 348 Line 349 Line 350 This changed the semantics - before we would raise before we run the hook, now we would run the hook when no vm is running, and then fail in getStats() Line 263: """ Line 264: Lock user session in guest operating system using guest agent. Line 265: """ Line 266: self.vm.guestAgent.desktopLock() Line 267: if self.vm.guestAgent.isResponsive(): > +1 If you create a variable, I would do: ga = self.vm.guestAgent ga.desktopLock() if ga.isResponsive(): ... But I think the version Francesco submitted is more readable. We so such optimizations for tight loops since accessing local variables is much faster then globals or objects attributes. Line 268: return {'status': doneCode} Line 269: else: Line 270: return errCode['nonresp'] Line 271: -- To view, visit https://gerrit.ovirt.org/61475 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e2e238fc632df97b63f7bb2a6293fe1c392a842 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Irit Goihman <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
