Dan Kenigsberg has posted comments on this change.
Change subject: vdsm.spec: Add packages versions for rhel7
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm.spec.in
Line 80:
Line 81: %if 0%{?rhel}
Line 82: %if 0%{?rhel} >= 7
Line 83: ExclusiveArch: x86_64
Line 84: # Subprocess and thread bug was found on python 2.7.2
I do not believe that 2.7.2 would be an issue in el7.
in any case, please drop the repeated comment.
Line 85: Requires: python >= 2.7.3
Line 86: Requires: qemu-kvm >= 2:1.2.0
Line 87: Requires: qemu-kvm-img >= 2:1.2.0
Line 88: Requires: libvirt >= 0.10.1-1
Line 85: Requires: python >= 2.7.3
Line 86: Requires: qemu-kvm >= 2:1.2.0
Line 87: Requires: qemu-kvm-img >= 2:1.2.0
Line 88: Requires: libvirt >= 0.10.1-1
Line 89: Requires: libvirt-python, libvirt-lock-sanlock, libvirt-client
this seems to be just the same as in others branches, please take out of the
%if.
Line 90: Requires: iscsi-initiator-utils >= 6.2.0.872-14
Line 91: Requires: device-mapper-multipath >= 0.4.9-18
Line 92: Requires: e2fsprogs >= 1.41.14
Line 93: Requires: kernel >= 3.6
--
To view, visit http://gerrit.ovirt.org/9428
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia556789f9a2456f255d822f7e28877168d603f6e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
