Dan Kenigsberg has submitted this change and it was merged. Change subject: net: Split OVS setup transaction to adjust for bond setup ......................................................................
net: Split OVS setup transaction to adjust for bond setup When using Linux bonds (instead of OVS bonds), the OVS setup transaction needs to be split into two. First one for removing networks and a second for adding networks. In between, the bonds setup is placed. These three steps contain, in addition to the actual devices setup, the acquire and running-config update, allowing proper rollback in case of setup failure. This patch, fixes a scenario that fails with the previous patch, where the Linux bonds have been introduced in the setup flow. The scenario: Move a network nic from a network to a bond slave. Change-Id: I0bd351e755be9d5dcaf5a05e5b79345e6f7bcfe8 Bug-Url: https://bugzilla.redhat.com/1379115 Signed-off-by: Edward Haas <edwa...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/64118 Continuous-Integration: Jenkins CI Reviewed-by: Petr Horáček <phora...@redhat.com> Reviewed-by: Dan Kenigsberg <dan...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/64412 --- M lib/vdsm/network/netswitch.py M lib/vdsm/network/ovs/switch.py M tests/network/ovs_switch_test.py M tests/network/ovs_test.py 4 files changed, 111 insertions(+), 91 deletions(-) Approvals: Jenkins CI: Passed CI tests Petr Horáček: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Edward Haas: Verified -- To view, visit https://gerrit.ovirt.org/64412 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0bd351e755be9d5dcaf5a05e5b79345e6f7bcfe8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
