Eduardo has uploaded a new change for review. Change subject: Remove Pool.isMember() function. ......................................................................
Remove Pool.isMember() function. Related to BZ#878894. Change-Id: I648c22f4914ed3d13994b7c5049fc6083f02633f Signed-off-by: Eduardo <[email protected]> --- M vdsm/storage/hsm.py M vdsm/storage/sp.py 2 files changed, 3 insertions(+), 8 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/9454/1 diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index 358876d..e47eee1 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -269,8 +269,10 @@ @classmethod def validatePoolSD(cls, spUUID, sdUUID): - if not cls.getPool(spUUID).isMember(sdUUID): + pool = cls.getPool(spUUID) + if sdUUID not in pool.getDomains(): raise se.StorageDomainNotMemberOfPool(spUUID, sdUUID) + return pool @classmethod def validateNonDomain(cls, sdUUID): diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py index ac5e1db..25134d5 100644 --- a/vdsm/storage/sp.py +++ b/vdsm/storage/sp.py @@ -1618,13 +1618,6 @@ return domainslist @unsecured - def isMember(self, sdUUID, checkActive=False): - """ - Check if domain is member in the pool. - """ - return sdUUID in self.getDomains(activeOnly=checkActive) - - @unsecured def isActive(self, sdUUID): return sdUUID in self.getDomains(activeOnly=True) -- To view, visit http://gerrit.ovirt.org/9454 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I648c22f4914ed3d13994b7c5049fc6083f02633f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
