Zhou Zheng Sheng has posted comments on this change.
Change subject: pep8: fix libvirtconnection.py
......................................................................
Patch Set 1: Verified; I would prefer that you didn't submit this
(1 inline comment)
Pass autobuild.sh. Examine the changes with pydiff. The first change is
introducing a variable named "passwd", the second one is "!=" to "is not" when
comparing with None. Both are acceptable.
....................................................
File vdsm/libvirtconnection.py
Line 73: except:
Line 74: cif.log.error("Error running VM callback", exc_info=True)
Line 75:
Line 76: __connections = {}
Line 77: __connectionLock = threading.Lock()
__connections and __connectionLock are module level variables to be used in
function get() below, so I think they should be placed closer to get() than
__eventCallback(). Can you insert an extra blank line before __connections
definition?
Line 78:
Line 79:
Line 80: def get(cif=None):
Line 81: """Return current connection to libvirt or open a new one.
--
To view, visit http://gerrit.ovirt.org/9437
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6fef13e80b2330dbc65c3440ceb994c5c6903b5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
