Royce Lv has posted comments on this change. Change subject: Move hsm.validatePoolSD() -> pool.validatePoolSD(). ......................................................................
Patch Set 1: I would prefer that you didn't submit this (2 inline comments) .................................................... File vdsm/storage/sp.py Line 455: @unsecured Line 456: def getMasterVersion(self): Line 457: return self.getMetaParam(PMDK_MASTER_VER) Line 458: Line 459: # TODO: Remove or rename this function. without @unsecured we'll need setSafe() to run this function Line 460: def validatePoolSD(self, sdUUID): Line 461: if sdUUID not in self.getDomains(): Line 462: raise se.StorageDomainNotMemberOfPool(self.spUUID, sdUUID) Line 463: return True Line 458: Line 459: # TODO: Remove or rename this function. Line 460: def validatePoolSD(self, sdUUID): Line 461: if sdUUID not in self.getDomains(): Line 462: raise se.StorageDomainNotMemberOfPool(self.spUUID, sdUUID) Why not just raise StorageDomainNotInPool here? Line 463: return True Line 464: Line 465: @unsecured Line 466: def validateAttachedDomain(self, dom, domainStatuses): -- To view, visit http://gerrit.ovirt.org/9455 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ba16c8a427c9478ae81c2693d79b8bd601f1ec3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Royce Lv <lvro...@linux.vnet.ibm.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
