Michal Skrivanek has posted comments on this change. Change subject: net: Ignore missing graphics from VM conf on target host ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/64300/1/vdsm/virt/vm_migrate_hook.py File vdsm/virt/vm_migrate_hook.py: Line 82: raise VmMigrationHookError('No devices entity in VM conf') Line 83: Line 84: try: Line 85: _set_graphics(devices, target_vm_conf) Line 86: except VmMigrationMissingDisplayConf: > I am not sure if that will be even correct. it is definitely eventually going to be dropped, so yes, it should be documented when it's no longer relevant Line 87: # Due to a bug in Engine, there can be a scenario where the domxml Line 88: # includes a graphics section, however, the VM config on target does Line 89: # not. In such cases, ignore and do not touch this section. Line 90: pass -- To view, visit https://gerrit.ovirt.org/64300 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8cc730c6448b1f70500c86b3ab39af21fa23bd5a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmire...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
