Michal Skrivanek has posted comments on this change. Change subject: draft: vm_migration_libvirt_hook_plugins ......................................................................
Patch Set 4: >During vm migration we invoke a libvirt hook: vm_migrate_hook.py. >This was added recently, and adds some special ovs handling to our >vNics. >But, this change broke all hooks which relied on modifying the nic >domxml, >like: vmfex, openstack, and now the ovn hook. >These hooks applied custom changes to the NIC xml. yes. And that should have been avoided in the first place. >These custom changes were now lost, as a result of vm_migrate_hook >applying >the special ovs handling. >So we needed a way to disable this special handling for some of the >NICs. IMO you should stop modifying libvirt xml unless it is something we can't really avoid, not without a discussion with libvirt team, without a plan how to get rid of such modification. Alternatively - if there is a fundamental disagreement between the responsibilities/ownership of networks then we need to work with libvirt to resolve that. We can't rely on libvirt for migration and "step on their things" at the same time. >Please note that this is not something that introduces something >new, but >something which tries to fix the functionality broken by >introducing the >libvirt hook. Again, I would much rather try to discuss all the other options to be able to avoid such a hook. >So far everyone agrees that this is not a nice solution, but so far >no one >was able to suggest any better. >If you don't agree with the way this is solved, please suggest a >nicer >alternative. The fact that the problematic libvirt hook was merged is unfortunate. I suggest to discuss and revisit the whole problem and design a proper sustainable solution -- To view, visit https://gerrit.ovirt.org/64001 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e13a94fa28968e37cd2d4d99fe540c8b762f7cc Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmire...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmire...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
