Nir Soffer has posted comments on this change. Change subject: qemuimg: Add the command to QImgError ......................................................................
Patch Set 5: Code-Review+1 (2 comments) Looks good, just minor indentation issue. https://gerrit.ovirt.org/#/c/65179/4/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line 219: self._aborted = False Line 220: self._progress = 0.0 Line 221: Line 222: self._stdout = bytearray() Line 223: self._stderr = bytearray() Please move cmd to next line... Line 224: Line 225: self.cmd = cmdutils.wrap_command(cmd, Line 226: with_nice=utils.NICENESS.HIGH, Line 227: with_ioclass=utils.IOCLASS.IDLE) https://gerrit.ovirt.org/#/c/65179/5/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line 223: self._stderr = bytearray() Line 224: Line 225: self.cmd = cmdutils.wrap_command(cmd, Line 226: with_nice=utils.NICENESS.HIGH, Line 227: with_ioclass=utils.IOCLASS.IDLE) And indent all the params one per line, starting at column 5. Line 228: _log.debug(cmdutils.command_log_line(self.cmd, cwd=cwd)) Line 229: self._command = CPopen(self.cmd, cwd=cwd, Line 230: deathSignal=signal.SIGKILL) Line 231: self._stream = utils.CommandStream( -- To view, visit https://gerrit.ovirt.org/65179 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I226a54b29ae4afc3854056efea78767383b89619 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
