Laszlo Hornyak has posted comments on this change. Change subject: [WIP] add host-cpu to api ......................................................................
Patch Set 5: (1 inline comment) .................................................... File vdsm/libvirtvm.py Line 750: Line 751: #cpu-host support Line 752: # see http://wiki.ovirt.org/wiki/Features/Cpu-host_Support Line 753: if 'cpuMode' in self.conf: Line 754: cpu.setAttribute('mode', self.conf.get('cpuMode')) Imo in that way we will just mess up the cpuType. We will soon need a cpuType=custom and a cpuType=host-model and what we choose here is not actually a cputype, but the mode we are using the cpu. Line 755: Line 756: # This hack is for backward compatibility as the libvirt does not allow Line 757: # 'qemu64' guest on intel hardware Line 758: if model == 'qemu64' and not '+svm' in features: -- To view, visit http://gerrit.ovirt.org/9367 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9d107deec2f00912878161348ba639eaa6c4f07 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Deepak C Shetty <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
