Edward Haas has posted comments on this change. Change subject: net: canonicalize IPv4 prefix to netmask ......................................................................
Patch Set 2: Code-Review-1 (1 comment) The -1 is mainly for the commit message. The scenario where both prefix and mask are supplied is missing, but it should appear in a unit test not in an expensive func test. We should open a task to cover the canonicalize module with unit tests. https://gerrit.ovirt.org/#/c/64507/2//COMMIT_MSG Commit Message: Line 11: canonicalize.py. Line 12: Line 13: It also adds missing 'prefix' to setupNetworks documentation. Line 14: Line 15: Change-Id: I344eef120b4c19f90d4dd20c7857bb73ab259e9b Missing some lines to indicate it is a backport. Line 16: Bug-Url: https://bugzilla.redhat.com/1374194 -- To view, visit https://gerrit.ovirt.org/64507 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I344eef120b4c19f90d4dd20c7857bb73ab259e9b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
