Nir Soffer has posted comments on this change. Change subject: storagetestlib: Add sdVersion param to the test API. ......................................................................
Patch Set 2: Looks good, now we need to add a test to make sure our testing infrastructure works. I think there are existing tests for fake_env, you can enhance them with permutations for the sd version. -- To view, visit https://gerrit.ovirt.org/65308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9759fa6d8b2bd7c359fd188d1e18ffbba5004941 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org