Nir Soffer has posted comments on this change. Change subject: tests: Refine TerminationTests names ......................................................................
Patch Set 5: (3 comments) https://gerrit.ovirt.org/#/c/65326/5//COMMIT_MSG Commit Message: Line 5: CommitDate: 2016-10-13 03:07:01 +0300 Line 6: Line 7: tests: Refine TerminationTests names Line 8: Line 9: - Al the test are testing termination, there is no point in repeating > For all the tests that test termination there is no need to repeat... Done Line 10: the class name in the test names. Line 11: - Use the tests name to describe the situation tested; terminating a Line 12: running process, or kill failure. Line 13: - Rename fake_kill to fail; this name can be used later for other Line 7: tests: Refine TerminationTests names Line 8: Line 9: - Al the test are testing termination, there is no point in repeating Line 10: the class name in the test names. Line 11: - Use the tests name to describe the situation tested; terminating a > test names Done Line 12: running process, or kill failure. Line 13: - Rename fake_kill to fail; this name can be used later for other Line 14: failure tests. Line 15: Line 10: the class name in the test names. Line 11: - Use the tests name to describe the situation tested; terminating a Line 12: running process, or kill failure. Line 13: - Rename fake_kill to fail; this name can be used later for other Line 14: failure tests. > what do you mean? how do you want to do it? (my questions based on the code I was planning to move this to a module function, and reuse the same function all the tests. When I added the next tests, I discovered that we cannot reuse it since it should raise different exception and different text, so the best way is to have a nested function in the test. Hopefully more clear in the next version. Line 15: Line 16: Change-Id: Id085d7bbc65fe985454627e0958eb03d0e413b4d -- To view, visit https://gerrit.ovirt.org/65326 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id085d7bbc65fe985454627e0958eb03d0e413b4d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
