Francesco Romani has posted comments on this change. Change subject: vdsm: virt: add optional container support ......................................................................
Patch Set 51: (1 comment) https://gerrit.ovirt.org/#/c/53820/51/lib/vdsm/containerslib.py File lib/vdsm/containerslib.py: PS51, Line 99: def _is_cmd(argv, reqv): > Yeah I'm slightly torn. I understand only coupling state dependent function Looks slightly better if is a method, because of the functionality link. A nested function would probably be the better tool, but makes _execute too hard to read. let's stick with the method. -- To view, visit https://gerrit.ovirt.org/53820 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id236a30a5c875994c037b8d00c7463bceaab143f Gerrit-PatchSet: 51 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
