Milan Zamazal has posted comments on this change. Change subject: virt: Make DomainDescriptor use XML helpers ......................................................................
Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/55769/9/vdsm/virt/domain_descriptor.py File vdsm/virt/domain_descriptor.py: Line 25: def __init__(self, xmlStr): Line 26: self._xml = xmlStr Line 27: self._dom = vmxml.parse_xml(xmlStr) Line 28: self._devices = vmxml.find_first(self._dom, 'devices', None) Line 29: self._devices_hash = hash(vmxml.export_xml(self._devices) > parse/export? litle strange. How about parse/format? Perhaps, I'll change it to format_xml in the next upload. Line 30: if self._devices is not None else '') Line 31: Line 32: @classmethod Line 33: def from_id(cls, uuid): -- To view, visit https://gerrit.ovirt.org/55769 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib169735936d19171ff8b8d127666d7258c308f34 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
