Dan Kenigsberg has submitted this change and it was merged. Change subject: properties: Make password test data more clear ......................................................................
properties: Make password test data more clear The old test used the value b"12345678", which may confuse the maintainer of this file about to think that this may be a Unicode string. Replace with b"\x80\x81\x82\x83", which is clearly binary data, and also will fail to decode to Unicode using many encodings. Change-Id: Ifb507d5d728bc82a1698ed3191573f56f06323b0 Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: https://gerrit.ovirt.org/65258 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg <[email protected]> --- M tests/properties_test.py 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Nir Soffer: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/65258 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb507d5d728bc82a1698ed3191573f56f06323b0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
