Dominik Holler has posted comments on this change. Change subject: net: support nameserver address with %iface tail ......................................................................
Patch Set 1: Code-Review+1 (2 comments) Currently I only know that the zone id is used for local link addresses, for this reason I suggest to use a local link address as the sample address. https://gerrit.ovirt.org/#/c/65693/1/lib/vdsm/network/ip/validator.py File lib/vdsm/network/ip/validator.py: PS1, Line 61: 2001::1%eth0 The zone id is usually used for local link addresses. For this reason would be a local link address here more clean. https://gerrit.ovirt.org/#/c/65693/1/tests/network/ip_test.py File tests/network/ip_test.py: PS1, Line 87: 2001::1%eth1 The zone id is usually used for local link addresses. For this reason would be a local link address here more clean. -- To view, visit https://gerrit.ovirt.org/65693 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea4d2eea2af8004435dae54ad56588739e028ba2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dominik Holler <dhol...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
